Skip to content

Conversation

@bergatco
Copy link
Contributor

@bergatco bergatco commented Jan 12, 2024

Description

The aim of this spike is to evaluate how the edu-sharing search environment can best be integrated as a "learning store" within the school cloud network software.

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/DMED-119
hpi-schul-cloud/dof_app_deploy#713
hpi-schul-cloud/schulcloud-client#3387
hpi-schul-cloud/nuxt-client#2933
hpi-schul-cloud/oeh-search-etl#50

Links to deployments :
https://dmed-119-integration-of-search-environment.dbc.dbildungscloud.dev/
https://dmed-119-integration-of-search-environment.nbc.dbildungscloud.dev/
https://dmed-119-integration-of-search-environment.brb.dbildungscloud.dev/

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@bergatco bergatco closed this Jan 16, 2024
@bergatco bergatco deleted the DMED-119-integration-of-search-environment branch January 16, 2024 07:30
@bergatco bergatco restored the DMED-119-integration-of-search-environment branch March 20, 2024 12:45
@bergatco
Copy link
Contributor Author

Reopened due to new requirements (additional API endpoint for logging in to edu-sharing repository and receiving a valid ticket for the web component).

@bergatco bergatco reopened this Mar 20, 2024
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
72 Uncovered Lines on New Code (required ≤ 0)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-extend-activation-time do-not-merge WIP This feature branch is in progress, do not merge into master.

Development

Successfully merging this pull request may close these issues.