forked from ros2/ros1_bridge
-
Notifications
You must be signed in to change notification settings - Fork 4
Ci test #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hsd-dev
wants to merge
30
commits into
master
Choose a base branch
from
ci_test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue has been resolved.
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
* fix removing obsolete ROS 2 service bridges Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * include utility Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
…os2#263) * deprecate package key for service parameters, use full type instead Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * added const to local variables Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
…pairs (ros2#268) * Fixed issue where explicitly mapped packages with the same package/service name cause redefinition errors Signed-off-by: Gavin Suddrey <g.suddrey@qut.edu.au> * Removing unneeded whitespace Signed-off-by: Gavin Suddrey <g.suddrey@qut.edu.au>
…os2#272) Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
…#279) Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
… dynamic_bridge (ros2#282) * add factory API to create ROS 2 pubs/subs with rclcpp QoS Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * add API to create bridges with rclcpp QoS Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * use hardcoded QoS (keep all, transient local) for /tf_static topic Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * feedback cleaner code Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * fix compile error of previous commit Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * update existing code the same way Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com> * simplify qos construction Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
… rosidl_adapter and .msg files (ros2#296) * update to use rosidl_parser and .idl files rather than rosidl_adapter and .msg files Signed-off-by: William Woodall <william@osrfoundation.org> * fix quote style linting error Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
* very minor typo in comments * Fix other copy-paste typos. Co-authored-by: Steven! Ragnarök <nuclearsandwich@users.noreply.github.com> Co-authored-by: tomoya <Tomoya.Fujita@sony.com>
* Fix logging for updated rclcpp interface Signed-off-by: Michael Carroll <michael@openrobotics.org> * Update src/bridge.cpp Signed-off-by: Michael Carroll <michael@openrobotics.org> Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> * Update to pass char * Signed-off-by: Michael Carroll <michael@openrobotics.org> * Uncrustify Signed-off-by: Michael Carroll <michael@openrobotics.org> Co-authored-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
ros2#310 (comment) Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
build times are not a concern and it is not significantly improved when using ros-tooling actions Signed-off-by: Harsh Deshpande <harshavardhan.deshpande@ipa.fraunhofer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.