Skip to content

Conversation

@tolgacangoz
Copy link
Contributor

@tolgacangoz tolgacangoz commented Dec 14, 2025

This PR adds transformer cache context for SkyReels-V2 pipelines and & updates docs.

Copilot AI review requested due to automatic review settings December 14, 2025 12:10
- [SkyReels-V2 I2V 14B - 720P](https://huggingface.co/Skywork/SkyReels-V2-I2V-14B-720P-Diffusers)
- [SkyReels-V2 FLF2V 1.3B - 540P](https://huggingface.co/Skywork/SkyReels-V2-FLF2V-1.3B-540P-Diffusers)

This model was contributed by [M. Tolga Cangöz](https://github.com/tolgacangoz).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- [SkyReels-V2 I2V 1.3B - 540P](https://huggingface.co/Skywork/SkyReels-V2-I2V-1.3B-540P-Diffusers)
- [SkyReels-V2 I2V 14B - 540P](https://huggingface.co/Skywork/SkyReels-V2-I2V-14B-540P-Diffusers)
- [SkyReels-V2 I2V 14B - 720P](https://huggingface.co/Skywork/SkyReels-V2-I2V-14B-720P-Diffusers)
- [SkyReels-V2 FLF2V 1.3B - 540P](https://huggingface.co/Skywork/SkyReels-V2-FLF2V-1.3B-540P-Diffusers)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FLF2V was producing bad results at the 1.3B model; I didn't even create its HF repo, but put it here as a placeholder at that time.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds transformer cache context support to SkyReels-V2 pipelines to enable caching optimizations during inference. The cache contexts separate conditional and unconditional forward passes with "cond" and "uncond" labels respectively.

  • Wraps transformer calls with cache_context() for both conditional and unconditional predictions
  • Applies the pattern consistently across all five SkyReels-V2 pipeline variants
  • Updates documentation with contributor credit (unrelated change)

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/diffusers/pipelines/skyreels_v2/pipeline_skyreels_v2_i2v.py Wraps conditional and unconditional transformer calls with cache_context("cond") and cache_context("uncond")
src/diffusers/pipelines/skyreels_v2/pipeline_skyreels_v2_diffusion_forcing_v2v.py Wraps conditional and unconditional transformer calls with cache_context("cond") and cache_context("uncond")
src/diffusers/pipelines/skyreels_v2/pipeline_skyreels_v2_diffusion_forcing_i2v.py Wraps conditional and unconditional transformer calls with cache_context("cond") and cache_context("uncond")
src/diffusers/pipelines/skyreels_v2/pipeline_skyreels_v2_diffusion_forcing.py Wraps conditional and unconditional transformer calls with cache_context("cond") and cache_context("uncond")
src/diffusers/pipelines/skyreels_v2/pipeline_skyreels_v2.py Wraps conditional and unconditional transformer calls with cache_context("cond") and cache_context("uncond")
docs/source/en/api/pipelines/skyreels_v2.md Removes FLF2V model listing and adds contributor credit (unrelated to cache context changes)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tolgacangoz tolgacangoz changed the title Add transformer cache context for SkyReels-V2 pipelines Add transformer cache context for SkyReels-V2 pipelines & Update docs Dec 14, 2025
@tolgacangoz tolgacangoz requested a review from Copilot December 14, 2025 12:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- [SkyReels-V2 I2V 14B - 540P](https://huggingface.co/Skywork/SkyReels-V2-I2V-14B-540P-Diffusers)
- [SkyReels-V2 I2V 14B - 720P](https://huggingface.co/Skywork/SkyReels-V2-I2V-14B-720P-Diffusers)
- [SkyReels-V2 FLF2V 1.3B - 540P](https://huggingface.co/Skywork/SkyReels-V2-FLF2V-1.3B-540P-Diffusers)

Copy link

Copilot AI Dec 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A model listing line for "SkyReels-V2 FLF2V 1.3B - 540P" appears to have been removed from the supported models list. If this model is no longer supported or was listed incorrectly, this change should be documented in the PR description to explain why it was removed.

Suggested change
> **Note:** The model "SkyReels-V2 FLF2V 1.3B - 540P" is no longer listed as a supported model. It was removed from the list as it is not currently supported in Diffusers, or was previously listed in error.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant