Skip to content

When customizing the save path, modify the "save_details" location #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Guncuke wants to merge 2 commits into
base: main
Choose a base branch
from
Open

When customizing the save path, modify the "save_details" location #1092

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e50a267
update
Guncuke Nov 29, 2025
b8fba55
update
Guncuke Nov 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/lighteval/logging/evaluation_tracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ def save_results(self, date_id: str, results_dict: dict):
org = org_model_parts[0] if len(org_model_parts) >= 2 else ""
model = org_model_parts[1] if len(org_model_parts) >= 2 else org_model_parts[0]
output_dir = self.output_dir
output_dir_results = Path(self.results_path_template.format(output_dir=output_dir, org=org, model=model))
output_dir_results = Path(self.results_path_template.format(output_dir=output_dir, org=org, model=model)) / "results"
else:
output_dir_results = Path(self.output_dir) / "results" / self.general_config_logger.model_name.strip("/")
self.fs.mkdirs(output_dir_results, exist_ok=True)
Expand All @@ -315,7 +315,15 @@ def save_results(self, date_id: str, results_dict: dict):
f.write(json.dumps(results_dict, cls=EnhancedJSONEncoder, indent=2, ensure_ascii=False))

def _get_details_sub_folder(self, date_id: str):
output_dir_details = Path(self.output_dir) / "details" / self.general_config_logger.model_name.strip("/")
if self.results_path_template is not None:
org_model_parts = self.general_config_logger.model_name.split("/")
org = org_model_parts[0] if len(org_model_parts) >= 2 else ""
model = org_model_parts[1] if len(org_model_parts) >= 2 else org_model_parts[0]
output_dir = self.output_dir
output_dir_details = Path(self.results_path_template.format(output_dir=output_dir, org=org, model=model)) / "details"
else:
output_dir_details = Path(self.output_dir) / "details" / self.general_config_logger.model_name.strip("/")

if date_id in ["first", "last"]:
# Get all folders in output_dir_details
if not self.fs.exists(output_dir_details):
Expand Down Expand Up @@ -747,4 +755,4 @@ def push_to_tensorboard( # noqa: C901
logger.info(
f"Pushed to tensorboard at https://huggingface.co/{self.tensorboard_repo}/{output_dir_tb}/tensorboard"
f" at global_step {global_step}"
)
)
Loading