Align GRPO and RLOO initialization #4685
Open
+51
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
commented
Dec 12, 2025
Comment on lines
120
to
131
| from datasets import load_dataset | ||
| from trl import RLOOTrainer | ||
| from trl.rewards import accuracy_reward | ||
| dataset = load_dataset("trl-lib/tldr", split="train") | ||
| def reward_func(completions, **kwargs): | ||
| # Dummy reward function that rewards completions with more unique letters. | ||
| return [float(len(set(completion))) for completion in completions] | ||
| dataset = load_dataset("trl-lib/DeepMath-103K", split="train") | ||
| trainer = RLOOTrainer( | ||
| model="Qwen/Qwen2-0.5B-Instruct", | ||
| reward_funcs=reward_func, | ||
| reward_funcs=accuracy_reward, | ||
| train_dataset=dataset, | ||
| ) | ||
| trainer.train() |
| model_name = model_name.split("/")[-1] | ||
| args = RLOOConfig(f"{model_name}-RLOO") | ||
|
|
||
| # Models |
qgallouedec
requested review from
albertvillanova,
edbeeching,
kashif and
lewtun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GRPO recently benefited from some improvements in initialization that were not applied to RLOO. This PR aligns the two initializations.