pMap docstring + error catching #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibratu
commented
Feb 19, 2025
andreibratu
commented
- p-map dependency could not be adequately imported in some node configurations
- Removed the dependency and added a homebrewed implementation; the implementation is not 1:1 with the dependency (e.g. not all options available), but preserves the logic we're interested in
jamesbaskerville
approved these changes
Feb 19, 2025
Contributor
jamesbaskerville
left a comment
jamesbaskerville
left a comment
There was a problem hiding this comment.
seems reasonable to me -- tested and works?
Author
|
@jamesbaskerville yep, tested with cookbook examples + jordan's demo app. For SDLC, we should replicate the integration tests from Python in TS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.