Add Windows instructions, and update the example script #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added windows instructions and updated dependcy versions
Replace deprecated and removed scipy.ndimage.imread
Make sure all images displayed are sharing a common colour-range for the colourmap, otherwise you can be decieved as to the output looking less-similar than it actually is.
Owner
|
Hi Zak, thanks for the fixes/ updates! Did you by any chance confirm that the updated compile instructions still work for Ubuntu/Linux or only on Windows? |
Author
|
I did not confirm that they work for linux sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated dependencies to more modern versions and since scipy.ndimage.imread no longer exists and as recommended in the docs has been replaced with imageio.imread, preserving mode 'L' using the ITU-R 601-2 luma transform.
Additionally we make sure the imshow() call has vmin=0, vmax=255 for all images, as otherwise the range displayed will be different for the three images, making the reconstruction look worse than it actually is. For example in one run I get the minimum and maximum of the ground truth to be 20 and 247, whilst our reconstruction is 7 and 274. This expanded range makes the reconstruction look like it cannot reproduce dark blacks, or bright whites in the final image.