Skip to content

Conversation

@jsiebens
Copy link

@jsiebens jsiebens commented Jul 9, 2020

I'm using this flash utility to write raspian and ubuntu images but I would like to copy multiple custom files to /boot.
This pull request adds the ability to do this with multiple -F/--file flags like: flash --file usercfg.txt --file network-config ...

jsiebens added 2 commits July 9, 2020 10:20
Signed-off-by: Johan Siebens <johan.siebens@gmail.com>
Signed-off-by: Johan Siebens <johan.siebens@gmail.com>
Copy link
Member

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. That looks good so far.
Could you update the usage and the README.md that it‘s possible to use —file multiple times?
At least the README should show an example for multiple files as you showed in the PR description.
Adding a test would be super cool, if you have time.

jsiebens added 2 commits July 10, 2020 10:14
Signed-off-by: Johan Siebens <johan.siebens@gmail.com>
Signed-off-by: Johan Siebens <johan.siebens@gmail.com>
@jsiebens jsiebens requested a review from StefanScherer July 10, 2020 08:31
@jsiebens
Copy link
Author

Hi, thanks for the feedback. I've added some additional info on how to copy multiple files and also added a test case.

Signed-off-by: Johan Siebens <johan.siebens@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants