More update for numpy 2.0 casting changes in product __add__ #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #439 +/- ##
==========================================
- Coverage 72.23% 69.15% -3.08%
==========================================
Files 78 76 -2
Lines 8085 8090 +5
==========================================
- Hits 5840 5595 -245
- Misses 2245 2495 +250 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
samaloney
force-pushed
the
bugfix-py311-packages
branch
from
c9048fd to
03db081
Compare
nicHoch
approved these changes
Nov 14, 2025
| data["timedel"] = duration | ||
| data.add_meta(name="timedel", nix="NIX00405", packets=packets) | ||
| data["triggers"] = triggers.astype(get_min_uint(triggers)) | ||
| data["triggers"] = triggers.astype(np.min_scalar_type(triggers)) |
Collaborator
There was a problem hiding this comment.
nice that this is common numpy now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding two products need to ensure the index
dtypecolumn is sufficient to hold the combine number of rows.