Make capitalization of room names look more natural #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An attempt to make the use of room names in sentences more natural. This affects listing exits, "can't go that way" messages, looking into adjacent rooms, and reporting travelling longer distances. Changes things like "We can see Slango's Bunk that way" to "We can see Slango's bunk that way." Also tries to deal with proper-named rooms that have a definite article, such as The Counterfeit Monkey or The Aquarium bookstore. Not sure if the approach used, making them improper-named, is the best one, though.
This reverts commit 1b344a5.
angstsmurf
changed the title
angstsmurf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to make the use of room names in sentences more natural. This affects listing exits, "can't go that way" messages, looking into adjacent rooms, and reporting travelling longer distances.
Changes things like "We can see Slango's Bunk that way" to "We can see Slango's bunk that way."
Also tries to deal with proper-named rooms that have a definite article, such as The Counterfeit Monkey or The Aquarium bookstore. Not sure if the approach used, making them improper-named, is the best one, though.