feat: v6.2.0 upgrade script
#329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Le-Caignec
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the upgrade infrastructure to perform a Solidity v8 migration for all PoCo facets to version 6.2.0.
Key changes:
- Creates comprehensive upgrade script that removes all existing Solidity v6 facets and deploys new Solidity v8 versions
- Permanently removes the IexecERC20Facet from the codebase
- Updates GitHub Actions workflow to use the new upgrade script
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/upgrades/v6.2.0.ts | New upgrade script implementing the Solidity v8 migration for all facets on Arbitrum Sepolia and Mainnet |
| scripts/upgrades/v6.2.0.md | Documentation for the v6.2.0 upgrade including summary of changes and deployment log structure |
| .github/workflows/upgrade-facets.yml | Updates workflow to reference the new v6.2.0.ts upgrade script |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
scripts/upgrades/v6.2.0.ts
Outdated
Comment on lines
139
to
141
| name: 'IexecAccessorsABILegacyFacet', | ||
| address: null, | ||
| factory: new IexecAccessorsABILegacyFacet__factory(), |
Contributor
There was a problem hiding this comment.
check with user if this ABI legacy facet is still needed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #329 +/- ##
=======================================
Coverage 96.38% 96.38%
=======================================
Files 33 33
Lines 1134 1134
Branches 228 228
=======================================
Hits 1093 1093
Misses 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gfournierPro
approved these changes
Nov 14, 2025
…alization for middleware team review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For testing :
On Arbitrum testnet
ARBITRUM_SEPOLIA_FORK=true npx hardhat node --no-deployARBITRUM_SEPOLIA_FORK=true npx hardhat run scripts/upgrades/v6.2.0.ts --network external-hardhatOn Arbitrum One Mainnet
ARBITRUM_FORK=true npx hardhat node --no-deployARBITRUM_FORK=true npx hardhat run scripts/upgrades/v6.2.0.ts --network external-hardhatThose three facets — ,
IexecPoco2Facet,IexecPocoAccessorsFacet, andIexecOrderManagementFacet— are not mandatory to be deployed because nothing has changed in their source code except the import statements.For this PR, I chose to deploy them so that the main branch remains as consistent as possible with the code currently deployed on-chain.