-
Notifications
You must be signed in to change notification settings - Fork 1
feat: use websocket for client server communication (previously enabled by EXPERIMENTAL_WS_API)
#225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🐳 Hadolint Dockerfile Lint ResultsClick to expand detailed resultsapi/Dockerfile:4 DL3018 warning: Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>` |
EXPERIMENTAL_WS_API)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR switches from the experimental websocket API (previously enabled by EXPERIMENTAL_WS_API flag) to making it the default communication protocol, removing the HTTP-based fallback entirely. The change simplifies the client-server communication by using websockets exclusively.
Key changes:
- Removed the
EXPERIMENTAL_WS_APIfeature flag and websocket conditional logic - Deprecated HTTP endpoints and handlers in favor of websocket communication
- Added deprecation warnings for old features including HTTP endpoints, legacy templates, and scone versions
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| cli/src/utils/sconify.ts | Removed HTTP fallback logic, now uses websockets exclusively |
| cli/src/utils/featureFlags.ts | Removed useWsApi feature flag |
| cli/src/config/config.ts | Removed HTTP API URL constant |
| api/src/sconify/sconifyBuild.handler.ts | Renamed HTTP handler to deprecated, added deprecation warnings |
| api/src/sconify/deprecated_sconify.handler.ts | Added deprecation warnings to legacy handlers |
| api/src/index.ts | Updated to use deprecated HTTP handler |
| api/src/constants/constants.ts | Updated comments to mark legacy features as deprecated |
| api/README.md | Updated documentation to reflect websocket-first API design |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Co-authored-by: Robin Le Caignec <72495599+Le-Caignec@users.noreply.github.com>
This PR switches the communication protocol to the previously experimental websocket API