Skip to content

Conversation

@zguesmi
Copy link
Member

@zguesmi zguesmi commented Oct 6, 2025

No description provided.

@zguesmi zguesmi changed the title Feat/dvn config script wip: Set DVN config Oct 6, 2025
@zguesmi zguesmi changed the title wip: Set DVN config feat: Set DVN config Oct 6, 2025
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.92%. Comparing base (7dcf930) to head (e5bce70).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #107   +/-   ##
=======================================
  Coverage   83.92%   83.92%           
=======================================
  Files           4        4           
  Lines         112      112           
  Branches        7        7           
=======================================
  Hits           94       94           
  Misses         17       17           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zguesmi zguesmi changed the title feat: Set DVN config feat: Implement DVN config script Nov 7, 2025
@zguesmi zguesmi self-assigned this Nov 7, 2025
@zguesmi zguesmi marked this pull request as ready for review November 7, 2025 15:35
Copilot AI review requested due to automatic review settings November 7, 2025 15:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds LayerZero configuration support for bridge setup, including executor and ULN (Universal Layer Network) configurations. The changes enable setting security parameters (DVNs, confirmations) and executor settings for cross-chain messaging.

  • Adds new LzConfig struct and functions to read/set LayerZero configurations
  • Updates bridge configuration script to include executor and ULN config setup
  • Adds test coverage for the new configuration functions

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
test/units/bridges/layerZero/IexecLayerZeroBridgeConfigureScript.t.sol Adds test for setExecutorAndUlnConfigIfNeeded and helper function to build mock LZ configs
src/RLCCrosschainToken.sol Removes unused import IAccessControl
script/utils/LayerZeroUtils.sol Adds functions to get/set/log bridge LZ configs; changes function visibility from public to internal
script/lib/ConfigLib.sol Adds LzConfig struct and readLzConfig function; refactors VM constant and config file path
script/bridges/layerZero/IexecLayerZeroBridge.s.sol Updates configure script to accept and use LZ configs for executor and ULN setup
docs/LayerZeroSetup.md Adds new documentation file with production checklist links
config/config.json Adds LayerZero configuration parameters (libraries, executor, DVNs) for all chains
README.md Adds link to production setup documentation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

function setExecutorAndUlnConfigIfNeeded(LzConfig memory srcChainLzConfig, LzConfig memory dstChainLzConfig)
public
returns (bool)
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO check if the config is needed.

* @param srcChainConfig The LayerZero configuration parameters for the source chain.
* @param dstChainConfig The LayerZero configuration parameters for the destination chain.
*/
function setBridgeLzConfig(LzConfig memory srcChainConfig, LzConfig memory dstChainConfig) internal {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function setBridgeLzConfig(LzConfig memory srcChainConfig, LzConfig memory dstChainConfig) internal {
function setBridgeLzExecutorAndDvnConfig(LzConfig memory srcChainConfig, LzConfig memory dstChainConfig) internal {

vm.stopPrank();
}

// TODO implement other tests.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests for "ifNeeded" part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants