-
Notifications
You must be signed in to change notification settings - Fork 4
Fix for issue: #20 #22
base: master
Are you sure you want to change the base?
Conversation
|
@0x00-0xFF sorry for the late response, I was on vacation and fully offline. Could you elaborate a bit more on this PR? Why is this change necessary. |
|
@iMicknl seems to me that this solves the acces denied error, running your master version doesn't allow me to use the api. using the version in branch of @0x00-0xFF works without a hiccup. |
|
|
||
| payload = { | ||
| "grant_type": "password", | ||
| "client_id": "pwAndroidApp", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would changing pwAndroidApp to pwWebApp not be enough? I am not sure why the whole call should be changed.
However if this fixes the problem, I am happy to merge and publish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm this fixes the autorisation issues in Home Assistant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to release this fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@scornelissen85 sure! But to be honest I am not sure if this will fix it.
I did plan to do a full rewrite of the integration, however I have been more busy than expected lately, thus this will take a few weeks.
Were you able to confirm that this change still works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iMicknl what are your thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peternijssen the approach mentioned above feels a bit hacky, but looks doable.
I just bought a house and I am in the planning and hopefully soon moving process, thus a bit more busy lately. However, this is certainly something I want for my new house ;-).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GoGoGadget 💯 let's hope this can be implemented and can result again in a working PostNL function at home assistant 🤓
Good luck moving @iMicknl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried the fix menionted, but that still does not work for me.
Also, the procedure is very different, it uses a shell script which places a cookie and scraped the html pages into tmp files.
The login procdure constist of a number of steps, with some generated tokens/codes/challenges and such.
A python script must probably do the same, which might be a challenge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peternijssen did you get a reply back from PostNL? I had a look at the shell file and it doesn't work for me, and indeed as @Romkabouter mentions; they use scraping which I would like to avoid..

No description provided.