Servos #18
Open
Servos #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/components/Servo.js
Outdated
| value: number; | ||
| } | ||
|
|
||
| class Switch extends Component { |
Contributor
There was a problem hiding this comment.
Should be Servo, right?
Contributor
|
Should probably export the Servo component in |
Owner
Author
|
I knew I was much too tired while working on this. Thank you for the keen eyes, @edvinerikson. |
iamdustan
force-pushed
the
servos
branch
2 times, most recently
from
c6d9f93 to
a957c47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took the tests modified from #17 but modified for a flattened API.
After experimenting with the firmata API directly I’m fairly convinced that exposing
servoConfigas a property in any capacity would be a weak DX. Additionally, from looking at other libraries built on top of firmata they often introduced other concepts.min/max may not be the best terms for this and I still don’t have a really solid grasp on how the min/max and writing a value interact (I think the servo I’m testing with needs to be calibrated or I just need to learn more about how hardware and electronics work).
The initial Servo implementation is pretty barebones as well. In due time we may very well want to introduce transition timing properties to it.