Fix: Add sqlalchemy.types.DOUBLE to dependency version specification #166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue #165.
Introduction of a dependency on sqlalchemy.types.DOUBLE starting with version v0.4.2.
The DOUBLE type was introduced in SQLAlchemy version 2.0, as documented here:
https://docs.sqlalchemy.org/en/20/core/type_basics.html#sqlalchemy.types.Double
However, SQLAlchemy versions prior to 2.0 (e.g., 1.4.54) do not include the DOUBLE type in their types module:
https://github.com/sqlalchemy/sqlalchemy/blob/rel_1_4_54/lib/sqlalchemy/types.py
Currently, the project does not reflect this dependency on SQLAlchemy 2.0 or higher in several places:
The README states compatibility with SQLAlchemy versions between 0.7.3 and 2.0.x
The feedstock recipe does not specify a lower bound on the SQLAlchemy version
The setup.py requires only 'sqlalchemy>=0.7.3'
This PR updates the dependency specifications and documentation to explicitly require SQLAlchemy version 2.0 or newer, ensuring compatibility with the use of sqlalchemy.types.DOUBLE and avoiding runtime import errors.