Feature/#336 base screen #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikbendewilliam
suggested changes
Oct 16, 2024
|
|
||
| class BaseScreen extends StatelessWidget { | ||
| final bool isScrollable; | ||
| final bool useSlivers; |
Contributor
There was a problem hiding this comment.
Good idea to add more functionality, we can do even better imo
Add the ability to show an error by having a String and/or a onRetryPressed. But do make the visualisation a separate widget like you do with _content and _header
Contributor
Author
There was a problem hiding this comment.
Is it ok if i do this in a separate PR? There have been a lot of changes after this including the redesign, so might be better to add this after those are merged (or based upon those branches)
luca-vz
previously approved these changes
Jan 22, 2025
jorre127
changed the base branch from
feature/#349-add-remote-config
to
master
ikbendewilliam
previously approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #336