Skip to content

parentNode check for orphaned element references fix #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sean-roberts wants to merge 2 commits into
base: master
Choose a base branch
from
Open

parentNode check for orphaned element references fix #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2639bf4
Fixing parentNode missing issue -- adding it as a prereq check
Sep 3, 2015
70c7476
Updating stale reference post injection
Sep 3, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions svg-injector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,12 @@
return;
}

// If we don't have a parentNode we can not replace the node inline
if (!el.parentNode) {
callback('Attempted to process an image that is not in the DOM. SVG to load:' + imgUrl);
return;
}

// Remember the request to inject this element, in case other injection
// calls are also trying to replace this element before we finish
injectedElements.push(el);
Expand Down
21 changes: 21 additions & 0 deletions tests/race-condition/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,20 @@
<img id="thumb-up-two" class="inject-me-twice thumb-icon" data-src="assets/svg/thumb-up.svg" title="I like it!" alt="thumb up">
<img id="thumb-up-three" class="inject-me-three-times thumb-icon" data-src="assets/svg/thumb-up.svg" title="I like it!" alt="thumb up">

<img id="thumb-up-errors" class="thumb-icon" data-src="assets/svg/thumb-up.svg" style="fill:plum;" title="I like it!" alt="js errors">


<script src="js/svg-injector.min.js"></script>
<script>

window.onerror = function(e){
// visually identify catch js errors
document.getElementById('thumb-up-errors').setAttribute('style', 'fill:maroon');
};

SVGInjector(document.getElementById('thumb-up-errors'));


// Stress Test...

// Call the same injection call lots of time to try and trigger a race condition
Expand Down Expand Up @@ -94,6 +104,17 @@
console.log('[Three] We injected ' + totalSVGsInjected + ' SVG(s)!');
});


(function(){

// Attempt to run SVG injection on an orphaned element
var orphan = document.createElement('img');
orphan.setAttribute('data-src', 'assets/svg/thumb-up.svg');

// Make sure we don't throw a parentNode is null error
SVGInjector(orphan);
})();

</script>
</body>
</html>