Skip to content

Prototype.js compatibility #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
howard wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Prototype.js compatibility #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5f05c0
Improved compatibility with JS used by Magento
howard Jul 23, 2015
3df8847
Reproduce Prototype.js incompatibility in test
howard Nov 24, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions svg-injector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,8 +259,11 @@
}

// Copy all the data elements to the svg
var imgData = [].filter.call(el.attributes, function (at) {
return (/^data-\w[\w\-]*$/).test(at.name);
var imgData = [];
forEach.call(el.attributes, function (attribute) {
if ((/^data-\w[\w\-]*$/).test(attribute.name)) {
imgData.push(attribute);
}
});
forEach.call(imgData, function (dataAttr) {
if (dataAttr.name && dataAttr.value) {
Expand Down
4 changes: 4 additions & 0 deletions tests/prototype-compatibility/assets/svg/thumb-up.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
17 changes: 17 additions & 0 deletions tests/prototype-compatibility/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8">
<title>SVGInjector Test: Prototype.js Compatibility</title>
</head>
<body>
<img class="inject-me" data-src="assets/svg/thumb-up.svg">

<script src="js/prototype.js"></script>
<script src="../../svg-injector.js"></script>
<script>
// Attempting injection fails asynchronously before f5f05c010.
SVGInjector(document.querySelectorAll('img.inject-me'));
</script>
</body>
</html>
Loading