Fix rgba error #50
Merged
Fix rgba error #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed legacy function C_Reputation.GetFactionDataByID(factionID) behavior
idiomatic
reviewed
Nov 30, 2024
HandyNotes_Achievements.lua
Outdated
| tooltip:SetFont(GameTooltipTextSmall) | ||
| local genderSuffix = (UnitSex("player") == 3 and "_FEMALE") or "" | ||
| local reputation = HNA:RGBToColorCode(FACTION_BAR_COLORS[standing]) .. _G["FACTION_STANDING_LABEL" .. standing .. genderSuffix] .. "|r" | ||
| --local genderSuffix = (UnitSex("player") == 3 and "_FEMALE") or "" |
idiomatic
reviewed
Nov 30, 2024
HandyNotes_Achievements.lua
Outdated
| local tooltip | ||
| local activeNodes = {} | ||
|
|
||
| local _, ns = ... |
Owner
There was a problem hiding this comment.
for simplicity, merge ns.api and HNA objects, and remove ns?
Owner
|
consider adding an appropriate message to CHANGELOG.md and adjusting the |
Removed dead code + used HNA object instead of new one
idiomatic
approved these changes
Nov 30, 2024
Owner
|
@Psykotik if you wish, hit the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed legacy function C_Reputation.GetFactionDataByID(factionID) to behave as intended