port to freebsd #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello John,
Please find two patches in this pull request which make manardb compile and pass its tests in a BSD environment (I'm working on an i386 FreeBSD 10.0, but it should work on other BSDs as well). The one patch substitutes a munmap + mmap for Linux's mremap, per your advice in the Portability section of the project page. (the PROTECTION and SHARING arguments have to be stored in the MTAGMAP structure between the call to MTAGMAP-OPEN and a subsequent MTAGMAP-RESIZE). The other patch just fixes a careless mistake in STORE-ALL-SYMBOLS-TEST; it surprises me how this managed to survive unnoticed for five years.
Yours,
— B. Smilga.