git: set update = none for all submodules so that cargo git dependencies don't clone them
#1574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
force-pushed
the
kkysen/submodule-update-none
branch
from
43b79bf to
ded2b7f
Compare
…ncies don't clone them `cargo` always recursively clones git dependencies, even though c2rust git dependencies don't need any of the big submodules here used just for testing. Setting `update = none` is workaround (see <rust-lang/cargo#10717>). However, other users need to explicitly update submodules now. With this change, it takes ~6 s to resolve a `c2rust-bitfields` git dependency, vs. many minutes before with all of the large submodules.
kkysen
force-pushed
the
kkysen/submodule-update-none
branch
from
ded2b7f to
a101fbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c2rust-side fix for Avoid /opt path dependency for c2rust-bitfields GaloisInc/Tractor-Crisp#46.cargoalways recursively clones git dependencies, even though c2rust git dependencies don't need any of the big submodules here used just for testing. Settingupdate = noneis workaround (see rust-lang/cargo#10717). However, other users need to explicitly update submodules now.With this change, it takes ~6 s to resolve a
c2rust-bitfieldsgit dependency, vs. many minutes before with all of the large submodules.