add Lasse (tasty!) and fix unit tests #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
According to Elvis:
Missing space after "," on line 18
Member
There was a problem hiding this comment.
According to Elvis:
Line 18 is too long: -spec datetime_to_json(({{integer(),integer(),integer()},{integer(),integer(),integer()}})) -> binary()..
Member
There was a problem hiding this comment.
If you move to OTP 18.x you don't need to change datetime() for a tuple.
Member
|
@benhsu you should merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
My efforts to learn Erlang continue.
I was getting a runtime error around Lasse not started, so I added Lasse to the app.src file.
I also found that the code was returning things like {drawn, NewMatch} but the unit test was looking for a naked 'drawn' atom, so I fixed that
(I'm still getting some errors in gun and shotgun, I haven't had time during the week to pop into the chat room about them but they seem to be related to those dependencies being out of date)
Thank you for helping me learn Erlang.