Skip to content

Conversation

@super-nabla
Copy link
Contributor

@super-nabla super-nabla commented Jul 7, 2025

Essentially, the key update involves a shift to a more comprehensive parsing strategy, moving beyond line-by-line tokenisation. I've aimed to make the code more modular and readable, which I hope will contribute to easier maintenance.

See also the internationalisation guidelines at Meta: https://meta.wikimedia.org/wiki/Meta:Internationalization_guidelines

@gopavasanth
Copy link
Member

@super-nabla, please review the workflow and make some updates accordingly.. Thanks!

@super-nabla
Copy link
Contributor Author

@gopavasanth ok, done. Thank you for reviewing. :)
I had to adjust a few of the existing tests slightly. For example, based on https://meta.wikimedia.org/wiki/Meta:Internationalization_guidelines inline icons should be wrapped in "tvar" and not tagged with "translate".

[[File:smiley.png|alt=🙂]]

I also added new test cases as required.

Copy link
Member

@gopavasanth gopavasanth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@gopavasanth gopavasanth merged commit f8d89c9 into indictechcom:main Jul 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants