Skip to content

Conversation

@alexfikl
Copy link
Contributor

This just adds a baseline.json file so that it's there.

@inducer
Copy link
Owner

inducer commented Nov 10, 2025

Why is that a good thing?

@alexfikl
Copy link
Contributor Author

Why is that a good thing?

For context, I was going around doing a basedpyright --writebaseline to see if everything's ok and this made the repo dirty and confused me. I can't say I feel strongly either way though, it was just a in-the-moment PR :\

@inducer
Copy link
Owner

inducer commented Nov 10, 2025

Thanks for explaining! I'm not sure either. My reason for not wanting it is that I feel the baselines are sort of a crutch on the way to a perfectly type-happy future. (which codepy, in no small part thanks to your efforts has already achieved!) At the same time I can also see the workflow uniformity benefits, and many places are going to have baselines for a long time. I can't get myself to feel strongly about either approach. 🤷 You?

@alexfikl
Copy link
Contributor Author

You?

Yeah, let's leave it.. we don't need more useless hidden files!

@alexfikl alexfikl closed this Nov 10, 2025
@alexfikl alexfikl deleted the add-dummy-baseline branch November 10, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants