Attempt to fix inter-volume trace pair functions #243
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majosm
force-pushed
the
cross-rank-inter-volume-trace-pairs
branch
from
8c86c98 to
012341d
Compare
inducer
reviewed
Mar 28, 2022
grudge/trace_pair.py
Outdated
| return 0 | ||
| else: | ||
| ary_tag = (comm_tag, key) | ||
| return staple_distributed_send( |
Owner
There was a problem hiding this comment.
Make the send separately from stapling it.
Closed
majosm
force-pushed
the
cross-rank-inter-volume-trace-pairs
branch
from
81b7b7e to
4c7292e
Compare
majosm
force-pushed
the
cross-rank-inter-volume-trace-pairs
branch
from
97915bd to
0603005
Compare
majosm
force-pushed
the
cross-rank-inter-volume-trace-pairs
branch
from
0603005 to
730e0b4
Compare
majosm
force-pushed
the
cross-rank-inter-volume-trace-pairs
branch
2 times, most recently
from
16fe9e8 to
f25fe19
Compare
majosm
force-pushed
the
cross-rank-inter-volume-trace-pairs
branch
from
f25fe19 to
92d0a36
Compare
majosm
force-pushed
the
cross-rank-inter-volume-trace-pairs
branch
from
92d0a36 to
fb2cac5
Compare
majosm
force-pushed
the
cross-rank-inter-volume-trace-pairs
branch
from
fb2cac5 to
0f94e3d
Compare
majosm
force-pushed
the
cross-rank-inter-volume-trace-pairs
branch
2 times, most recently
from
6ae2cca to
1c76f6e
Compare
majosm
force-pushed
the
cross-rank-inter-volume-trace-pairs
branch
from
1c76f6e to
fd644cf
Compare
Collaborator
Author
test failure was caused by bug in test (that has since been fixed)
majosm
force-pushed
the
cross-rank-inter-volume-trace-pairs
branch
from
fd644cf to
12a6443
Compare
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I abandoned the previous one-way communication idea (I didn't know how to make this work in lazy, since there wouldn't be anything to staple the sends to). This PR is an attempt to implement a two-way version. Still untested.
Since the trace data is possibly heterogeneous in the multi-volume case, the sends in
_RankBoundaryCommunicationLazycan't be stapled to the receives anymore (since the sent and received data on a given rank will in general have different numbers of subarrays). As a workaround, I staple the sends to arrays of zeros with the same shape as the data being sent. Then I reduce the resulting array container of zeros to a scalar zero value, and add it to the trace pair data being returned so that something (hopefully) will depend on it.Depends on #239 (and inducer/meshmode#308).