Skip to content

Conversation

@aakashnarayan
Copy link

No description provided.

@inducer
Copy link
Owner

inducer commented Jul 23, 2022

Thanks! Could you look into the linter failure?

Also, this is missing documentation and tests. When writing the documentation, it might be good to remind the user that the stability region for forward Euler includes no nonzero part of the imaginary axis, and therefore forward Euler is unstable for DG operators applied to hyperbolic PDEs discretized with central fluxes.

@inducer
Copy link
Owner

inducer commented Jul 3, 2023

Please add a test and fix the linter. Converting to draft and unsubcribing in the meantime, please request review when ready.

@inducer inducer marked this pull request as draft July 3, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants