refactor: Generalize Substitutable::apply_ref #4499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marwes
force-pushed
the
type_visitor_2
branch
from
eb64e1a to
2e7bb2f
Compare
added 5 commits
March 29, 2022 16:07
Contributor
Author
|
ping @jsternberg |
jsternberg
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
apply_refa proper visitor.Substituteris kept (but should perhaps be renamed) and is extended with additional methods that allow the specificSubstututerto inject logic forPolyType. Through this we can implementmax_tvarandfree_varsin terms of the same visit method asapply.Extracted from #4388