This repository was archived by the owner on Sep 9, 2025. It is now read-only.
Introduce dev-doc for process management #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdoern
force-pushed
the
ilab-processes
branch
2 times, most recently
from
329a0e2 to
d62dad6
Compare
nathan-weinberg
requested review from
alinaryan,
jaideepr97,
n1hility and
nathan-weinberg
jaideepr97
reviewed
Nov 20, 2024
cdoern
force-pushed
the
ilab-processes
branch
5 times, most recently
from
6c832c4 to
fb61d35
Compare
6 tasks
reidliu41
reviewed
Nov 26, 2024
reidliu41
reviewed
Nov 26, 2024
reidliu41
reviewed
Nov 26, 2024
cdoern
force-pushed
the
ilab-processes
branch
2 times, most recently
from
4c5512e to
d7a9a07
Compare
danmcp
reviewed
Dec 6, 2024
cdoern
force-pushed
the
ilab-processes
branch
from
d7a9a07 to
3566472
Compare
jaideepr97
approved these changes
Dec 11, 2024
cdoern
force-pushed
the
ilab-processes
branch
from
3566472 to
8bf3bf8
Compare
cdoern
changed the title
nathan-weinberg
approved these changes
Dec 18, 2024
Member
nathan-weinberg
left a comment
nathan-weinberg
left a comment
There was a problem hiding this comment.
few nits but otherwise LGTM
ilab should be able to run detached processes, re-attach to them, and monitor them Signed-off-by: Charlie Doern <cdoern@redhat.com>
cdoern
force-pushed
the
ilab-processes
branch
from
8bf3bf8 to
4e1479c
Compare
Contributor
Author
|
This has been open for about a month now with two approvals. I am going to merge this as is, but I welcome and amendments in follow up PRs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ilab should be able to run detached processes, re-attach to them, and monitor them. This document introduces a first iteration of that process management