feat: generate banners for androidTV #581
Conversation
|
This would be a great addition for anyone developing for Android TV apps. Was hoping that it would already exist; and look at that: the code is already here and just needs to be merged. Would love to see it coming in (maybe as an active "cli arg" to activate since it may not be needed for most people). |
| androidIconForeground: await this.loadInputAsset('android/icon-foreground', AssetKind.Icon, Platform.Android), | ||
| androidIconBackground: await this.loadInputAsset('android/icon-background', AssetKind.Icon, Platform.Android), | ||
|
|
||
| androidBanner: await this.loadInputAsset('android/banner', AssetKind.Banner, Platform.Android), |
There was a problem hiding this comment.
The README update shows that the banner.png file should be placed in the assets/banner.png folder directly.
But it is not read that way. One has to place it in the assets/android/banner.png folder.
Is this intended? Then it should be noted in the README docs. Alternatively, and I think more logically, it should work in both folders regardless where it is placed.
There was a problem hiding this comment.
Also found that the banner addition seems to add the manifest line regardless android:banner="@drawable/banner" regardless if it's actually adding the banner (aka if the file is not in assets/android/banner.png it will still add the line in the AndroidManifest.xml)
There was a problem hiding this comment.
The PR places the files into the @drawable/banner but the banner.png file isn not placed into the res/drawable folder itself and only is placed in a very view select folders.
AndroidManifest.xml line also states that the images are to be found in the res/drawable format. But the docs (Source) state that the banner images should be placed next to the icon files in the mipmap folder structure.
There was a problem hiding this comment.
Dear @ThaUnknown, I hope you are still working with AndroidTV and can maybe adjust this PR to fix the issues above?
And @samanmohamadi, would it be possible to take a look at this and ideally complete / merge this for the ones developing for AndroidTV applications?
There was a problem hiding this comment.
I have low interest in trying to fix this, as I'm unsure as to how, this works for my app, which forces androidTV but idk about optionality
2 participants
This PR adds functionality to create banners for androidTV, they are close to horizontal splash screens, but sometimes marginally different
#580