This repository was archived by the owner on Jan 6, 2023. It is now read-only.
Handle 404 in upload.js #137
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently if a 404 is returned you get a json parsing error as seen in ionic-team/ionic-cli#1765 which is entirely unhelpful and pretty confusing. This change will show that a 404 was received and give relevant information to whoever gets the error. Something should probably be done to generally handle any case where the API will return HTML instead of JSON, but this will help alleviate some confusion in the mean time.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a 404 is returned you get a json parsing error as seen in ionic-team/ionic-cli#1765 which is entirely unhelpful and pretty confusing. This change will show that a 404 was received and give relevant information to whoever gets the error.
Something should probably be done to generally handle any case where the API will return HTML instead of JSON, but this will help alleviate some confusion in the mean time.