Skip to content

Conversation

@habdelra
Copy link

@habdelra habdelra commented Feb 2, 2021

fixes #20 add default export to buffer-es6.js module

@remorses
Copy link

Can this be merged please?

@lemoustachiste
Copy link

I am experiencing this issue but I am not sure of the side effects of this change.
It would be all in all a breaking change and it's not highlighted as such in the commit.
I think the better fix would be at the moment of injecting the code into the build, replacing import buffer from 'buffer' by import * as buffer from 'buffer'.

I am not a maintainer of this library so this is just my 2 cents trying to deal with this issue.

@ralyodio
Copy link

I'm needing this. For some reason I get an error when trying to do:

buffer: 'rollup-plugin-node-polyfills/polyfills/buffer-es6', as an alias in vite/sveltekit.

@ralyodio
Copy link

Can someone merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants