Refactor makefile, add ubuntu1804 and fix label bug #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stolsma
force-pushed
the
refactor-makefile
branch
4 times, most recently
from
91b21a3 to
ba95a08
Compare
Contributor
Contributor
Author
|
If we don't do support we also have to remove all the 18.04 specific build scripting IMHO. I don't think we are that far to decide on that, so that's why I added it to the CI build step. Then we at least will know when 18.04 doesn't work.... Also its only one reference to add at the moment so no big deal to add😉 |
Add Ubuntu 18.04 as checked base image. Refactor build, push and export steps Fix label bug where label data with comma is truncated Signed-off-by: stolsma <github@tolsma.net>
stolsma
force-pushed
the
refactor-makefile
branch
from
ba95a08 to
cb2afc4
Compare
Contributor
Author
|
Btw it should be ready for review after this last running check (I removed some debugging lines...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Ubuntu 18.04 as checked base image.
Refactor build, push and export steps
Fix label bug where label data with comma is truncated
Signed-off-by: stolsma github@tolsma.net