Skip to content

Conversation

@masih
Copy link
Member

@masih masih commented Jan 23, 2023

Change the implementation of HTTP delegated routing provider records to match the IPIP-337 specification. The specification was changed to use PUT.

Close request body after decoding when handling provide.

@welcome
Copy link

welcome bot commented Jan 23, 2023

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@masih masih requested a review from guseggert January 23, 2023 15:13
Change the implementation of HTTP delegated routing provider records to
match the IPIP-337 specification. The specification was changed to use
`PUT`.

Close request body after decoding when handling provide.
@masih masih force-pushed the masih/fix_provide_method branch from 33d2940 to 4fd6521 Compare January 23, 2023 15:19
@masih masih requested a review from lidel January 24, 2023 11:55
@Jorropo
Copy link
Contributor

Jorropo commented Jan 27, 2023

AFAIT you removed the PUT operations from the spec ipfs/specs#370.

Is it because you plan to open a new IPIP ? What is the source of truth here ?

@willscott
Copy link
Contributor

Is it because you plan to open a new IPIP ? What is the source of truth here ?

correct. the put hasn't been deferred from 337, but that doesn't mean we aren't working towards it and I believe the convention is that code comes before spec.

@masih
Copy link
Member Author

masih commented Jan 27, 2023

As soon as IPIP-337 is merged PR to add PUT back will be opened. For now, this PR fixes what's definitely not going to be, which is POST requests.

Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me then. 🙂

@masih masih merged commit cc954f1 into main Jan 27, 2023
@masih masih deleted the masih/fix_provide_method branch January 27, 2023 13:56
Jorropo pushed a commit to ipfs/go-libipfs-rapide that referenced this pull request Mar 23, 2023
* feat: use PublishOptions for publishing IPNS records
* chore: interface-go-ipfs-core v0.9.0

Co-authored-by: Marcin Rataj <lidel@lidel.org>

This commit was moved from ipfs/go-namesys@3f6313c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants