Skip to content

Define a go_package for protobuf, rename to a more unique ipns-record.proto #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guillaumemichel merged 4 commits into from
Jan 16, 2025
Merged

Define a go_package for protobuf, rename to a more unique ipns-record.proto #789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
02062d0
Define record.proto go_ package name
dereknola Jan 9, 2025
d39268a
Change record.proto to more unique ipns-record.proto
dereknola Jan 10, 2025
d0cd97a
Merge branch 'main' into main
guillaumemichel Jan 16, 2025
34a082c
changelog
guillaumemichel Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ The following emojis are used to highlight certain changes:
### Fixed

- `gateway` Fix redirect URLs for subdirectories with characters that need escaping. [#779](https://github.com/ipfs/boxo/pull/779)
- `ipns` Defined a `go_package` name in `ipns-record.proto` to avoid protobuf conflicts [#789](https://github.com/ipfs/boxo/pull/789)

### Security

Expand Down
270 changes: 270 additions & 0 deletions ipns/pb/ipns-record.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ipns/pb/record.proto → ipns/pb/ipns-record.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ syntax = "proto3";

package github.com.boxo.ipns.pb;

option go_package = ".;pb";
option go_package = "github.com/ipfs/boxo/ipns/pb";

// https://specs.ipfs.tech/ipns/ipns-record/#record-serialization-format
message IpnsRecord {
Expand Down
Loading
Loading