Skip to content

fix: ipns protobuf namespace conflict #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gammazero merged 3 commits into from
Jan 21, 2025

Prefer `go generate` to `Makefile` for code generation

fbe6ba1
Select commit
Loading
Failed to load commit list.
Merged

fix: ipns protobuf namespace conflict #794

Prefer `go generate` to `Makefile` for code generation
fbe6ba1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 21, 2025 in 0s

60.52% (+0.00%) compared to de52bc8

View this Pull Request on Codecov

60.52% (+0.00%) compared to de52bc8

Details

Codecov Report

Attention: Patch coverage is 72.22222% with 30 lines in your changes missing coverage. Please review.

Project coverage is 60.52%. Comparing base (de52bc8) to head (fbe6ba1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ipns/pb/record.pb.go 72.22% 29 Missing and 1 partial ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #794   +/-   ##
=======================================
  Coverage   60.52%   60.52%           
=======================================
  Files         245      245           
  Lines       31130    31130           
=======================================
+ Hits        18841    18842    +1     
+ Misses      10613    10611    -2     
- Partials     1676     1677    +1
Files with missing lines Coverage Δ
ipns/record.go 68.21% <ø> (ø)
ipns/pb/record.pb.go 72.22% <72.22%> (ø)

... and 11 files with indirect coverage changes

View more details on Codecov