feat: ipns v2 and v2 record combination and tests #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
laurentsenta
reviewed
Sep 7, 2023
laurentsenta
reviewed
Sep 7, 2023
laurentsenta
reviewed
Sep 7, 2023
laurentsenta
reviewed
Sep 8, 2023
laurentsenta
approved these changes
Sep 11, 2023
Contributor
laurentsenta
left a comment
laurentsenta
left a comment
There was a problem hiding this comment.
lgtm, thanks for applying the fixes.
it may be not obvious why we have these checks or why certain edge case fails/passes, added Hints to elaborate
Contributor
|
Results against Kubo master: Summary
|
Contributor
|
Results against Kubo latest: Summary
|
lidel
approved these changes
Sep 12, 2023
Member
lidel
left a comment
lidel
left a comment
There was a problem hiding this comment.
Thank you @hacdias! Lgtm. I will refer to these fixtures from IPIP-428.
I've added missing Hint to some V1/V2 test cases to make it self-explanatory for the reader why certain checks exist.
@laurentsenta I've resolved conflict with main, ok to merge?
5 tasks
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #144. Many IPNS tests. This fixtures can also later be re-used for when we add TTL. It also sets a nice precedent of adding a file where we programatically generate the fixtures in a language other than shell.