Add message path to ping command response

[jinglemansweep]

No description provided.

[Copilot]

Pull request overview

This PR adds network diagnostic capabilities to MeshBot by introducing ping and trace tools for mesh network operations. The changes enable the bot to perform actual network diagnostics like checking node connectivity and tracing routing paths through the mesh network. The PR also adds path length tracking to messages to understand how many hops messages take through the network.

Key changes:

• Added new ping_node and trace_path diagnostic tools that interact with the mesh network
• Implemented send_trace and send_trace_and_wait methods in the MeshCore interface with support for both mock and real implementations
• Extended MeshCoreMessage dataclass to track path length (number of hops) for received messages

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
src/meshbot/tools/network.py	New module implementing ping_node and trace_path diagnostic tools for mesh network troubleshooting
src/meshbot/tools/init.py	Updated to register the new network diagnostic tools
src/meshbot/meshcore_interface.py	Added path_len field to MeshCoreMessage; implemented send_trace/send_trace_and_wait methods in both mock and real interfaces; added trace response handling with event subscription
prompts/default.md	Updated bot prompt to clarify that ping/trace commands trigger actual network diagnostics rather than text responses

Comments suppressed due to low confidence (1)

src/meshbot/meshcore_interface.py:989

• This import of module asyncio is redundant, as it was previously imported on line 3.

            import asyncio

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The mock trace response format doesn't match what the trace_path tool expects. The tool in network.py lines 88-93 expects responses with a "path" key containing a list of steps with "hash" and "snr" fields, but these mock responses have "hop", "node", and "latency_ms" fields instead. This will cause the trace_path tool to display empty results when used with the mock interface.

Consider updating the mock responses to match the expected format:

responses = [
    {"path": [
        {"hash": "local", "snr": 0},
        {"hash": "node1", "snr": 15.5},
        {"hash": "node2", "snr": 12.3}
    ]}
]

Suggested change

	# Simulate mock trace responses
	responses = [
	{"hop": 0, "node": "local", "latency_ms": 0},
	{"hop": 1, "node": "node1", "latency_ms": 45},
	{"hop": 2, "node": "node2", "latency_ms": 92},
	]
	# Simulate mock trace responses in expected format
	responses = [
	{
	"path": [
	{"hash": "local", "snr": 0},
	{"hash": "node1", "snr": 15.5},
	{"hash": "node2", "snr": 12.3},
	]
	}
	]
	]

[Copilot]

The nested loop structure processes response.get("path", []) for each response and iterates through the path steps, but the outer loop variable i is never used. If multiple responses each contain their own path, this could result in duplicated or confusing output.

Consider clarifying the logic:

• If each response represents a separate trace result, label them accordingly (e.g., "Trace result 1:", "Trace result 2:")
• If only one response is expected, consider simplifying to just process responses[0]
• If responses represent incremental updates to the same path, clarify this in the comments

[Copilot]

The asyncio.Queue is instantiated without calling it as a function. This should be asyncio.Queue() with parentheses to actually create a queue instance. Without the parentheses, _trace_responses will be a reference to the Queue class itself, not an instance, which will cause AttributeErrors when trying to call .put(), .get(), or .empty() methods.

[Copilot]

The docstring states "check connectivity and measure latency" and "measure round-trip time", but the function only returns a boolean success/failure and doesn't actually measure or report any latency or round-trip time information. Consider either:

1. Updating the docstring to remove mentions of latency measurement: "Ping a mesh node to check connectivity."
2. Enhancing the function to actually measure and return latency information if that's a desired feature.

Suggested change

	"""Ping a mesh node to check connectivity and measure latency.
	This sends a status request to the specified node and waits for a response.
	Use this to test if a node is reachable and measure round-trip time.
	"""Ping a mesh node to check connectivity.
	This sends a status request to the specified node and waits for a response.
	Use this to test if a node is reachable.