Adding away-notify IRCv3 capability

[eaescob]

Changed s_user.c to broadcast AWAY when setting/unsetting. Removed MODE +a/-a broadcast. This is so we can notify away message as part of supporting this capability.

Created a method in send.c - to send specified pattern to all channels the user is a part of, this helps for away-notify.

[eaescob]

Ugh. I clearly did not disable all the formatting settings. I can try to remove those changes.

[patrick-irc]

Is AWAY still part of the burst? I think this was the biggest concern last time.

If not and +a is removed (also from burst), I think after netsplit we do not see if a user is away when doing WHOIS nick (not WHOIS nick nick) if he is not on common channels. I think this worked with +a.

[eaescob]

I changed m_away to send AWAY to servers instead of MODE +a/-a.

[patrick-irc]

As described above:

1. User goes AWAY on server1
2. server2 links to server1
3. AWAY is not shown in WHOIS user on server2

WHOIS 000AAAAAA

00:32 -!- 000AAAAAA [patrick@127.0.0.1]
00:32 -!-  ircname  : x
00:32 -!-  server   : irc.localhost [Debian ircd default configuration]
00:32 -!- End of WHOIS

WHOIS 000AAAAAA 000AAAAAA

00:32 -!- 000AAAAAA [patrick@127.0.0.1]
00:32 -!-  ircname  : x
00:32 -!-  server   : irc.localhost [Debian ircd default configuration]
00:32 -!-  away     : away message
00:32 -!-           : is a Secure Connection (SSL/TLS)
00:32 -!-  idle     : 0 days 0 hours 4 mins 4 secs [signon: Sat Jan 25 00:28:23 2025]
00:32 -!- End of WHOIS

with +a first WHOIS shows at least:

00:43 -!-  away     : Gone, for more info use WHOIS 000AAAAAA 000AAAAAA

[eaescob]

That’s how most ircds behave since AWAY isn’t sent as part of burst. It’s only broadcasted when away is changed. Why the notify extension was created. When a split server reconnects and user joins channel, away mode is notified. I can change it so away is also sent as part of burst but don’t see the point. The problem with umode is that the away reason is not sent. If the desire is to just show away, how about bursting away and use default/canned reason? Emilio Escobar / ***@***.***

…

On Fri, Jan 24, 2025 at 3:48 PM patrick ***@***.***> wrote: As described above: 1. User goes AWAY on server1 2. server2 links to server1 3. AWAY is not shown in WHOIS user on server2 WHOIS 000AAAAAA 00:32 -!- 000AAAAAA ***@***.*** 00:32 -!- ircname : x 00:32 -!- server : irc.localhost [Debian ircd default configuration] 00:32 -!- End of WHOIS WHOIS 000AAAAAA 000AAAAAA 00:32 -!- 000AAAAAA ***@***.*** 00:32 -!- ircname : x 00:32 -!- server : irc.localhost [Debian ircd default configuration] 00:32 -!- away : away message 00:32 -!- : is a Secure Connection (SSL/TLS) 00:32 -!- idle : 0 days 0 hours 4 mins 4 secs [signon: Sat Jan 25 00:28:23 2025] 00:32 -!- End of WHOIS with +a first WHOIS shows at least: 00:43 -!- away : Gone, for more info use WHOIS 000AAAAAA 000AAAAAA — Reply to this email directly, view it on GitHub <#67 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEQ2SNF24RBWI2GORW43ZT2MLGM3AVCNFSM6AAAAABVIPUFYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJTGYYDONZVGQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[patrick-irc]

Then I suggest to keep a and combine it with away-notify.

Adding AWAY to burst can cause serious issues as the burst now already takes 60 seconds and we do not know what happens if we add thousands of away messages.

[eaescob]

I’m not suggesting we add AWAY to burst. I’m suggesting we let this behave as-is/as-intended. AWAY isn’t broadcasted during burst, split servers will notify other clients upon JOIN from a client that’s away. Let whois nick nick do its thing. I don’t like the idea of mixing MODE a plus away-notify. It just doesn’t go well together. The PR, as-is, works as intended with the extension and how ircds normally behave. Emilio Escobar / ***@***.***

…

On Jan 26, 2025 at 8:46:45 AM, patrick ***@***.***> wrote: Then I suggest to keep a and combine it with away-notify. Adding AWAY to burst can cause serious issues as the burst now already takes 60 seconds and we do not know what happens if we add thousands of away messages. — Reply to this email directly, view it on GitHub <#67 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEQ2SKPPE34JDBAMY6HRQD2MUGPLAVCNFSM6AAAAABVIPUFYSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMJUGUYDAOBYGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[eaescob]

Changed PR to send MODE +a/-a on away/unaway and rely on the umode.