Update iping build to work with iRODS v4.3.0 #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in order to work with iRODS 4.3.0
Contributor
Author
|
This PR has been successfully tested with CentOS 7 and Ubuntu 18.04 Bionic. |
|
@Pansanel Thanks for this. How was this tested?
@SwooshyCueb Please review the cmake changes for possible issues. |
trel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modification of the
CMakeLists.txtfile are based on the content of theCMakeLists.txtfile from the irods_client_rest_cpp client project. Some unused includes have been removed from theiping.cpp.