Skip to content

603/event-survey-field-enhancement #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sxpydo wants to merge 7 commits into
base: main
Choose a base branch
from
Open

603/event-survey-field-enhancement #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8fb89d0
added title text for the event survey URL field, in the same way as w…
sxpydo May 14, 2025
b1e54bd
removed text URL from the prop
sxpydo May 15, 2025
2f618b2
updated eventSurvey type to empty doc file
sxpydo May 15, 2025
ff6ec48
Merge branch 'main' into shav/event-survey
sxpydo Jun 4, 2025
64b49cf
not part of this PR, however it might be nice to update the default d…
sxpydo Jun 5, 2025
ddda40e
feat: update eventSurvey field to single editable item in meta items
sxpydo Jun 5, 2025
f7ebd92
refactor: replace eventSurvey inline presenter with reusable EventSur…
sxpydo Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 37 additions & 1 deletion src/components/semantic/metaItems.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ export const MetaItems = asMetaItems({
reservations: ["Reservations", { presenter: ReservationsMetaPresenter }],
preResources: ["Pre-Resources", { presenter: ResourcesMetaPresenter }],
postResources: ["Post-Resources", { presenter: ResourcesMetaPresenter }],
eventSurvey: "Event Survey URL",
eventSurvey: ["Event Survey", { presenter: EventSurveyMetaPresenter }],
});

function ReservationsMetaPresenter(props: MetaItemPresenterProps<IsaacEventPage>) {
Expand Down Expand Up @@ -426,3 +426,39 @@ function ResourcesMetaPresenter({ doc, update, prop, name }: MetaItemPresenterPr
</>
);
}

export function EventSurveyMetaPresenter(props: MetaItemPresenterProps<Content>) {
// Ensure survey is always an object, never null
const survey = (props.doc[props.prop as keyof Content] as ExternalReference | null) ?? { title: "", url: "" };

// Update handler for a field
const updateSurvey = (newSurvey: Partial<ExternalReference>) => {
if (props.update) {
props.update({
...props.doc,
[props.prop]: {
...survey,
...newSurvey,
},
});
}
};

return (
<>
<Row>
<Col xs={5}>Title</Col>
<Col xs={5}>URL</Col>
</Row>
<Row>
<Col xs={5}>
<MetaItemPresenter doc={survey} update={updateSurvey} prop="title" name="Title" />
</Col>
<Col xs={5}>
<MetaItemPresenter doc={survey} update={updateSurvey} prop="url" name="URL" />
</Col>
<Col xs={2}></Col>
</Row>
</>
);
}
4 changes: 2 additions & 2 deletions src/services/emptyDocuments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,12 @@ const emptyDocuments: Document[] = [
altText: "",
id: "eventThumbnail",
},
date: 1722470400000,
date: 1743807600000,
numberOfPlaces: 20,
eventStatus: "CLOSED",
preResources: [],
postResources: [],
eventSurvey: "",
eventSurvey: [],
emailEventDetails: "Check the online events page for additional details.",
emailConfirmedBookingText: "",
emailWaitingListBookingText: "",
Expand Down