forked from isaacphysics/isaac-react-app
-
Notifications
You must be signed in to change notification settings - Fork 0
768 booster video cta #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mariusmarin-dev
wants to merge
11
commits into
main
Choose a base branch
from
768-booster_video_CTA
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+54
−20
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
e1bea78
768 - Implement booster video CTA on Events page
mariusmarin-dev 0c1f639
768 - Implement booster video CTA on Events page
mariusmarin-dev 4566cd3
768 - Implement booster video CTA on Events page
mariusmarin-dev c1c8493
768 - Implement booster video CTA on Events page
mariusmarin-dev d3f8281
768 - Implement booster video CTA on Events page
mariusmarin-dev 2dae107
768 - Implement booster video CTA on Events page
mariusmarin-dev cafa410
768 - Implement booster video CTA on Events page
mariusmarin-dev 2dff914
768 - Implement booster video CTA on Events page
mariusmarin-dev 16cdc0a
Merge remote-tracking branch 'origin/768-booster_video_CTA' into 768-…
mariusmarin-dev c02496a
768 - Implement booster video CTA on Events page
mariusmarin-dev 35eec38
Redirect link
mariusmarin-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there is good enough reason to disable es-lint here?
Is there another way which es-lint will accept this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, it doesn't like it and is not an issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we enforce es-lint so that we meet some standards within the codebase.
I know it is really annoying but we need to make sure we dont disable eslint otherwise there is no point having it in the first place.