Replace Elasticsearch client #744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove unused constructor
These should consistently use ObjectNode, not JsonData
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/main/java/uk/ac/cam/cl/dtg/segue/etl/ElasticSearchIndexer.java
Dismissed
Show dismissed
Hide dismissed
src/main/java/uk/ac/cam/cl/dtg/segue/search/ElasticSearchProvider.java
Dismissed
Show dismissed
Hide dismissed
src/main/java/uk/ac/cam/cl/dtg/segue/search/ElasticSearchProvider.java
Dismissed
Show dismissed
Hide dismissed
Properly nest the expected queries
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #744 +/- ##
==========================================
- Coverage 36.84% 36.76% -0.08%
==========================================
Files 540 545 +5
Lines 23642 23813 +171
Branches 2825 2834 +9
==========================================
+ Hits 8711 8756 +45
- Misses 14056 14175 +119
- Partials 875 882 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
generateBoolMatchQuery is deprecated; it would be nice to remove it entirely, but for now just replace it where it is straightforward to do so
This reverts commit 10eb803.
axlewin
commented
Jan 12, 2026
src/test/java/uk/ac/cam/cl/dtg/segue/search/ElasticSearchProviderTest.java
Show resolved
Hide resolved
axlewin
commented
Jan 13, 2026
…sticsearch-java-api
ObjectMappers are costly to create, but even using them is expensive. In these cases we did have ObjectNode and JsonNode structure and were mapping to simple List<String>; so instead of the heavyweight, just use streams to convert the Jackson wrapper classes into plain Java. (cherry picked from commit 6fdecfc)
jsharkey13
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the high-level REST client previously used for Elasticsearch with the new(er) Java API client. This is necessary to allow Elasticsearch to be upgraded from v7, but this PR does not actually upgrade the version.