Run mapper tests as part of maven test #748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #748 +/- ##
==========================================
+ Coverage 36.77% 38.12% +1.35%
==========================================
Files 545 545
Lines 23692 23692
Branches 2832 2832
==========================================
+ Hits 8712 9033 +321
+ Misses 14102 13785 -317
+ Partials 878 874 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
axlewin
changed the title
… hotfix/run-mapper-tests
This reverts commit e020840.
This was copied across from ContentMapperTest, but it's not relevant for QuestionValidationResponse subclasses
jsharkey13
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the mapper parameterised tests to use JUnit 4 so they can be run as part of
build-and-test.As expected, the tests failed (
ContentMapperTest.testDOtoDTOMapping:62 expected: <uk.ac.cam.cl.dtg.isaac.dos.content.DesmosEmbedding> but was: <uk.ac.cam.cl.dtg.isaac.dto.content.DesmosEmbeddingDTO>) until this fix was merged in.