Maintain search params on errors #1925
Draft
+1,182
−1,235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RR6+ only allows <Route/> and <React.Fragment/> as children of a <Routes/> block, even if the component returns one of these. As such, I have moved the tracking part of tracked routes into onPageLoad, the figure numbering into a parent of the router (TODO: test this works), and replaced StaticPageRoutes and ExternalRedirects with <Route/>-based equivalents.
The browser managed to detect and stop this when going to the page, but the jest 'browser' does not have this feature
A `<BrowserRouter/>` is apparently a different, simpler type of router to that generated via `createBrowserRouter` (the latter being a Data Router). Data Routers allow navigation blocking, so this change requires a mini overhaul of how routes are loaded into the app.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1925 +/- ##
==========================================
- Coverage 42.93% 42.78% -0.15%
==========================================
Files 572 572
Lines 23971 24039 +68
Branches 7877 7916 +39
==========================================
- Hits 10291 10286 -5
- Misses 13041 13112 +71
- Partials 639 641 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[the test is dependent on RR7. do not merge this without]