Fix generic qf not showing qs from user context on load #1936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a few tests to check this in future.
In as brief as I can, the
userobject is sometimes available on load (if you came via soft redirect), and sometimes not (if not). This means our originalpopulateFiltersFromAccountSettingsfunction was not running on soft reload, because theuserobject had not changed (thus not triggering the useEffect).I have fixed this by pulling the logic from
populateFiltersFromAccountSettingsinto external functions, which are also used in the initial values forsearchStagesandsearchExamBoardsprovided the user is available then. This means that no matter when the user is available, we always run the same logic.