Added fields to Acquisition StreamItem and Acquisition header #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansenms
reviewed
Sep 29, 2025
hansenms
reviewed
Sep 29, 2025
kekeke21
force-pushed
the
feature/edit_acquisition
branch
from
cb91355 to
9b87711
Compare
- Added AcquisitionPhase field to Acquisition StreamItem as an array of float to represent phase offset from center frequency during acquisition - Added acquisitionCenterFrequency field to AcquisitionHeader as optional uint64 to record center frequency in Hz make phase and center frequency for each acquisition field optional add generated code - Make acquisition label as optional - Acquisition phase is already an optional field as it is defined in record field just test passed on regenerated code as previous commit failed at unexpected EOF error for reading phantom.bin on python yardl
kekeke21
force-pushed
the
feature/edit_acquisition
branch
2 times, most recently
from
9322bc2 to
030ff6a
Compare
naegelejd
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes adding fields to the Acquisition and its header schema to accommodate spectroscopy data in mrd format. The three fields below are added to the acquisition YML file.
Edits to AcquisitionStreamItem
Edits to AcquisitionHeader
The additional fields are optional, maintaining compatibility with the current version of the mrd format. The PR includes regenerated code and passed the tests on justfile on python and cpp.