Skip to content

[TAS-111] [Task] [FIX] Manejo de Tablas / General Refactor #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ncontinanza merged 25 commits into from
Nov 18, 2024
Merged

[TAS-111] [Task] [FIX] Manejo de Tablas / General Refactor #33

ncontinanza merged 25 commits into from
Nov 18, 2024

Conversation

@AldoRastrelli
Copy link
Collaborator

@AldoRastrelli AldoRastrelli commented Nov 18, 2024 •
edited
Loading

[TAS-111] [Task] [FIX] Manejo de Tablas / General Refactor

Description

Manejo de tablas en la red para mantener la uniformidad entre nodos.

Changes

  • Fix typos & comments
  • Fix warnings
  • Remove TODO & add doc
  • Remove unwraps
  • Remove blank lines and some funcs
  • Implement duplicate tables in router
  • Fix buffer size para que el cliente reciba todo
  • Router puede ver ahora si un shard ya no está levantado, y eliminarlo de su red
  • Si el shard eliminado era el último nodo levantado, router empieza a usar su backend.
  • Si la tabla no existe en ninguno de los nodos, se le avisa al cliente
  • Duplicate tables verifica si además de crear, tiene o no que mandar información
  • Fix Client loop

Keep in mind

Checklist

[Check all of the boxes you match, and explain why if not checked]

  • New unit tests added. Why (if not): not needed
  • All unit tests passed

AldoRastrelli and others added 25 commits November 16, 2024 23:26
@AldoRastrelli
[FIX] Typos & comments
8306de9
@AldoRastrelli
Fix warnings
aed89aa
@AldoRastrelli
Remove TODO comments, add doc
67efdf2
@AldoRastrelli
Remove Unwraps
00bc4de
@AldoRastrelli
Remove blank lines and unneeded funcs
2251e97
@AldoRastrelli
[Router] Remove unwraps and implement duplicate tables
a8af58d
@AldoRastrelli
[Client] Fix buffer size
738c728
@AldoRastrelli
Remove extra write_all in client
1b8b304
@AldoRastrelli
Add SendQueryResult file, with custom errors
5a1f82f
@AldoRastrelli
Add count() func in shard_manager
054aa5c
@AldoRastrelli
Shards redistributes data, deletes closed shards and empties tables w…
ce0ef23 
…ithout dropping them
@AldoRastrelli
If table does not exists, message is send to client too
ef4071a
@AldoRastrelli
Remove 2 prints
93d720c
@AldoRastrelli
Cargo fmt
5f70df3
@AldoRastrelli
Remove local raft from Cargo.toml
6ecb266
@AldoRastrelli
[Router] Fix duplicate_tables & format response
426ec58
@AldoRastrelli
[WIP] [FIX] Client
ab84662
@AldoRastrelli
Fix duplicate_tables
7377cac
@AldoRastrelli
Cargo fmt
e9717c0
@AldoRastrelli
Update .json files and libsharding
8272459
@ncontinanza
Fix client
262bddd
@ncontinanza
Merge branch 'refactor/general-refactor' of github.com:isoprophlex/di…
3ab9fdd 
…stributed-postgres into refactor/general-refactor
@AldoRastrelli
Cargo fmt
15a48ce
@ncontinanza
Remove unused import
a25a8ac
@ncontinanza
Merge branch 'refactor/general-refactor' of github.com:isoprophlex/di…
df032fc 
…stributed-postgres into refactor/general-refactor
@ncontinanza ncontinanza merged commit ddb8006 into master Nov 18, 2024
1 check passed
@ncontinanza ncontinanza deleted the refactor/general-refactor branch November 18, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncontinanza ncontinanza ncontinanza approved these changes

@isoprophlex isoprophlex isoprophlex approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AldoRastrelli @ncontinanza @isoprophlex