feat: add v2 injection and removal #224
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ITBench v2 will offer the same faults as v1. However, it will differentiate in a couple of ways:
argument_specs.yamlfile that was a part of thefaultsrole.argument_specs.yamldoes not validate arguments: Covered mainly in point (1). However, for contributors, this means that this file will no longer be the point of contention for merge conflicts. Previously, multiple users adding faults around the same time caused annoyances via merge conflicts. By moving to the JSON library, this file will not be a source of headache for these types of scenarios.The actual behavior of most faults remained unchanged. While the v2 injector and remover cannot interact with a v1 injector and remover, the actual implementation is largerly the same.
Faults will different behavior will be described below:
waitersin order to restart the necessary workloads. This allows us to not maintain a list of workloads to restart, which can change due to otel-demo being an application that still receives active development.