Skip to content

Conversation

@TAbdiukov
Copy link

  • Make the script OS-Independent. Now mwscrape runs on Windows happily

  • Convert the script to Python 3
    (mwscrape2slob uses Python 3. Python 2.7 is soon to hit EOL, and is pretty much dead anyway)

  • Convert spaces to TABs

  • Create requirements.txt for "pip install -r requirements.txt"

  • Update setup.py
    ** Add tags related to script
    ** increment version :)
    ** Add things needed for mwscrape to be published onto PyPi
    ** Move all code to the root directory for convenience, in the similar manner to other script

  • Create & Add entries for gitignore
    ** ignore .slob in case they happened to be created in same directory
    ** ignore .zip that might be created to test out pip installation

P.S. if accepted, please run "python setup.py publish" to publish mwscrape onto PyPi

@bkuhls
Copy link

bkuhls commented Mar 21, 2020

Is your patch runtime-tested? Did you hit #13 (comment)?

@TAbdiukov
Copy link
Author

TAbdiukov commented Apr 5, 2020

Is your patch runtime-tested? Did you hit #13 (comment)?

@bkuhls

Apologies for a late reply. Yes, it's runtime tested - I scrapped the OWASP wiki, some reverse engineering wiki (dont remember any longer), and a few fandom-hosted wikis. No issues whatsoever

And no, didn't stumble across the problem from #13

Happy to do more runtime if need be, since I used mwscrape the last time maybe 6 months ago

@TAbdiukov
Copy link
Author

@bkuhls

I just re-uploaded changes to a separate sandbox branch where you can play around with them. PY3 seems to handle the script correctly

https://github.com/TAbdiukov/mwscrape-py3

Otherwise, since there are no changes since, I may refactor README, as well as the other things. I really hope the author publishes his work onto pypi, so other people can use the script flawlessly and easily as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants